Skip to content

Add webhook labels to FR file#15183

Merged
nul800sebastiaan merged 3 commits intoumbraco:v13/devfrom
mikecp:v13/Webhooks-Label-FR
Nov 30, 2023
Merged

Add webhook labels to FR file#15183
nul800sebastiaan merged 3 commits intoumbraco:v13/devfrom
mikecp:v13/Webhooks-Label-FR

Conversation

@mikecp
Copy link
Copy Markdown
Contributor

@mikecp mikecp commented Nov 11, 2023

I added the French translations for the labels related to webhooks.

Added webhooks labels translations
small update
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 11, 2023

Hi there @mikecp, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

update from context
@emmagarland
Copy link
Copy Markdown
Collaborator

Hi @mikecp,

Thanks for your PR to add webhook labels to the FR file.

Since it is targeting v13, I've tagged @nul800sebastiaan to merge it.

Best wishes

Emma

@emmagarland
Copy link
Copy Markdown
Collaborator

@mikecp once we are happy to do so, you or I could change the target branch so at that point, I can merge it.
Thanks!

@nul800sebastiaan nul800sebastiaan added release/no-notes Not directly part of the release (updating README, build scripts, tests, etc.) release/13.0.0 category/localization labels Nov 30, 2023
@nul800sebastiaan nul800sebastiaan merged commit 212b566 into umbraco:v13/dev Nov 30, 2023
@nul800sebastiaan
Copy link
Copy Markdown
Member

Looking good @mikecp ! Merged! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/localization category/ui User interface community/pr release/no-notes Not directly part of the release (updating README, build scripts, tests, etc.) release/13.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants