Skip to content

Add tree access to webhooks #15156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zeegaan merged 3 commits into from
Nov 7, 2023
Merged

Add tree access to webhooks #15156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0976c9f
Add tree access to webhooks
bjarnef Nov 7, 2023
9f2ebb1
Update authorize attribute
bjarnef Nov 7, 2023
bba49ce
Add webhooks tree policy
bjarnef Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Umbraco.Web.BackOffice/DependencyInjection/UmbracoBuilder.BackOfficeAuth.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,12 @@ private static void CreatePolicies(AuthorizationOptions options, string backOffi
policy.Requirements.Add(new TreeRequirement(Constants.Trees.LogViewer));
});

options.AddPolicy(AuthorizationPolicies.TreeAccessWebhooks, policy =>
{
policy.AuthenticationSchemes.Add(backOfficeAuthenticationScheme);
policy.Requirements.Add(new TreeRequirement(Constants.Trees.Webhooks));
});

options.AddPolicy(AuthorizationPolicies.TreeAccessDataTypes, policy =>
{
policy.AuthenticationSchemes.Add(backOfficeAuthenticationScheme);
Expand Down
2 changes: 1 addition & 1 deletion src/Umbraco.Web.BackOffice/Trees/WebhooksTreeController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Umbraco.Cms.Web.BackOffice.Trees;

[Authorize(Policy = AuthorizationPolicies.TreeAccessLogs)]
[Authorize(Policy = AuthorizationPolicies.TreeAccessWebhooks)]
[Tree(Constants.Applications.Settings, Constants.Trees.Webhooks, SortOrder = 9, TreeGroup = Constants.Trees.Groups.Settings)]
[PluginController(Constants.Web.Mvc.BackOfficeTreeArea)]
[CoreTree]
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.Common/Authorization/AuthorizationPolicies.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public static class AuthorizationPolicies
public const string TreeAccessDataTypes = nameof(TreeAccessDataTypes);
public const string TreeAccessPackages = nameof(TreeAccessPackages);
public const string TreeAccessLogs = nameof(TreeAccessLogs);
public const string TreeAccessWebhooks = nameof(TreeAccessWebhooks);
public const string TreeAccessTemplates = nameof(TreeAccessTemplates);
public const string TreeAccessDictionary = nameof(TreeAccessDictionary);
public const string TreeAccessRelationTypes = nameof(TreeAccessRelationTypes);
Expand Down