Aligned parameters on sync and async methods on IFileSource.#15128
Merged
Aligned parameters on sync and async methods on IFileSource.#15128
Conversation
bergmania
approved these changes
Nov 3, 2023
ronaldbarendse
approved these changes
Nov 3, 2023
Contributor
|
@bergmania We should either cherry-pick this commit into the |
bergmania
deleted the
v13/task/align-sync-async-methods-on-ifilesource
branch
Member
|
Everything in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small adendum to the work in this PR, where I added a parameter to a method in
IFileSource, but omitted to do so for the "sync" equivalent.This PR adds this to align the signatures on these methods.