Ensure additional preview URLs work on non-variant content#14995
Merged
Ensure additional preview URLs work on non-variant content#14995
Conversation
elit0451
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
#14773 added UI for the "additional preview URLs" feature implemented in #14479. Unfortunately, the "additional preview URLs" UI currently does not work with culture invariant content.
This PR fixes that issue. It is purely a client-side issue which has to do with the active variant election. See the code change 😄
Testing this PR
Try adding a
SendingContentNotificationnotification handler like the following, and ensure that the generated additional preview URLs are displayed for both variant and invariant content.