V12: Update ImageSharp V3 and Add Legacy V2 Project#14216
Merged
Conversation
Member
|
LGTM 👍 |
1 task
Contributor
|
Just a note about naming of the projects/packages: I would suggest always including the major version of the dependency, e.g. Besides being more clear on what major version the dependency is used, this will also be much better for future-proofing, especially if we'd like to support a future ImageSharp 4 dependency on our CMS v13 LTS version (which could then be released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes #14180 but instead of just upgrading the ImageSharp project to V3, it also adds the old V2 version as a separate project.
For more info see #14180
As for testing as also stated in the other PR, the tests should pass and you should be able to get a cropped image.