Skip to content

V10/feature/fixing flaky acceptance test #13473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nul800sebastiaan merged 11 commits into from
Nov 30, 2022
Merged

V10/feature/fixing flaky acceptance test #13473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fd586fc
Added additional timeout
andr317c Nov 24, 2022
83d9280
Fixed indentation
andr317c Nov 24, 2022
7b00d18
Removed unnecessary waiForTimeout
andr317c Nov 24, 2022
1af8477
Updated the name so the partial View Macro file can be deleted.
andr317c Nov 24, 2022
0487940
Added additional waitForTimeout because the pipeline is sometimes too…
andr317c Nov 24, 2022
e71b889
Added more timeout so the pipeline can save in time.
andr317c Nov 24, 2022
23bf149
Fixed so it can delete the correct package even if there is more than…
andr317c Nov 24, 2022
d82d6f1
Indentation!
andr317c Nov 24, 2022
6d66a0f
Added helper method for navigation to template.
andr317c Nov 24, 2022
1ca4b92
bumped versions
andr317c Nov 24, 2022
860eb6c
Fixed an issue where the template was auto saved so it didnt get a popup
andr317c Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions tests/Umbraco.Tests.AcceptanceTest/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tests/Umbraco.Tests.AcceptanceTest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"prompt": "^1.2.0"
},
"dependencies": {
"@umbraco/json-models-builders": "^1.0.0",
"@umbraco/playwright-testhelpers": "^1.0.11",
"@umbraco/json-models-builders": "^1.0.2",
"@umbraco/playwright-testhelpers": "^1.0.19",
"camelize": "^1.0.0",
"faker": "^4.1.0",
"form-data": "^4.0.0",
Expand Down
3 changes: 0 additions & 3 deletions tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Branding/logo.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import { expect } from "@playwright/test";
test.describe('Umbraco Logo Information', () => {

test.beforeEach(async ({ page, umbracoApi }) => {
// TODO: REMOVE THIS WHEN SQLITE IS FIXED
// Wait so we don't bombard the API
await page.waitForTimeout(1000);
await umbracoApi.login();
});

Expand Down
5 changes: 3 additions & 2 deletions tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/content.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,8 +553,9 @@ test.describe('Content tests', () => {

// Save and publish
await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey(ConstantHelper.buttons.saveAndPublish));
await umbracoUi.isSuccessNotificationVisible();

// Added additional time because it could fail on pipeline because it's not saving fast enough
await umbracoUi.isSuccessNotificationVisible({timeout:20000});

// Assert
const expectedContent = '<p>Acceptance test</p>'
await expect(await umbracoApi.content.verifyRenderedContent('/contentpickercontent', expectedContent, true)).toBeTruthy();
Expand Down
4 changes: 2 additions & 2 deletions tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/HelpPanel/systemInformation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test.describe('System Information', () => {
await umbracoApi.users.setCurrentLanguage(enCulture);
});

async function openSystemInformation(page: Page, umbracoUi : UiHelpers) {
async function openSystemInformation(page: Page, umbracoUi: UiHelpers) {
//We have to wait for page to load, if the site is slow
await umbracoUi.clickElement(umbracoUi.getGlobalHelp());
await expect(page.locator('.umb-help-list-item').last()).toBeVisible();
Expand Down Expand Up @@ -46,4 +46,4 @@ test.describe('System Information', () => {
// Close the help panel
await page.locator('.umb-button__content').last().click();
});
});
});
107 changes: 54 additions & 53 deletions tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Login/login.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,67 +1,68 @@
import { test, expect } from '@playwright/test';
import {test, expect} from '@playwright/test';

test.describe('Login', () => {

test.beforeEach(async ({ page }) => {
await page.goto(process.env.URL + '/umbraco');
});
test('Login with correct username and password', async ({page}) => {
test.beforeEach(async ({page}) => {
await page.goto(process.env.URL + '/umbraco');
});
test('Login with correct username and password', async ({page}) => {

let error = page.locator('.text-error');
await expect(error).toBeHidden();
let error = page.locator('.text-error');
await expect(error).toBeHidden();

// Action
await page.fill('#umb-username', process.env.UMBRACO_USER_LOGIN);
await page.fill('#umb-passwordTwo', process.env.UMBRACO_USER_PASSWORD);
await page.locator('[label-key="general_login"]').click();
await page.waitForNavigation();
// Action
await page.fill('#umb-username', process.env.UMBRACO_USER_LOGIN);
await page.fill('#umb-passwordTwo', process.env.UMBRACO_USER_PASSWORD);
await page.locator('[label-key="general_login"]').click();
await page.waitForNavigation();

// Assert
await expect(page).toHaveURL(process.env.URL + '/umbraco#/content');
let usernameField = await page.locator('#umb-username');
let passwordField = await page.locator('#umb-passwordTwo');
await expect(usernameField).toHaveCount(0);
await expect(passwordField).toHaveCount(0);
});
// Assert
await expect(page).toHaveURL(process.env.URL + '/umbraco#/content');
let usernameField = await page.locator('#umb-username');
let passwordField = await page.locator('#umb-passwordTwo');
await expect(usernameField).toHaveCount(0);
await expect(passwordField).toHaveCount(0);
});

test('Login with correct username but wrong password', async({page}) => {
const username = process.env.UMBRACO_USER_LOGIN;
const password = 'wrong';
test('Login with correct username but wrong password', async ({page}) => {
const username = process.env.UMBRACO_USER_LOGIN;
const password = 'wrong';

// Precondition
let error = page.locator('.text-error');
await expect(error).toBeHidden();
// Precondition
let error = page.locator('.text-error');
await expect(error).toBeHidden();

// Action
await page.fill('#umb-username', username);
await page.fill('#umb-passwordTwo', password);
await page.locator('[label-key="general_login"]').click();
// Action
await page.fill('#umb-username', username);
await page.fill('#umb-passwordTwo', password);
await page.locator('[label-key="general_login"]').click();

// Assert
let usernameField = await page.locator('#umb-username');
let passwordField = await page.locator('#umb-passwordTwo');
await expect(error).toBeVisible();
await expect(usernameField).toBeVisible();
await expect(passwordField).toBeVisible();
});
// Assert
let usernameField = await page.locator('#umb-username');
let passwordField = await page.locator('#umb-passwordTwo');
await expect(error).toBeVisible();
await expect(usernameField).toBeVisible();
await expect(passwordField).toBeVisible();
});

test('Login with wrong username and wrong password', async({page}) => {
const username = 'wrong-username';
const password = 'wrong';
test('Login with wrong username and wrong password', async ({page}) => {
const username = 'wrong-username';
const password = 'wrong';

// Precondition
let error = page.locator('.text-error');
await expect(error).toBeHidden();
// Precondition
let error = page.locator('.text-error');
await expect(error).toBeHidden();

// Action
await page.fill('#umb-username', username);
await page.fill('#umb-passwordTwo', password);
await page.locator('[label-key="general_login"]').click();
// Action
await page.fill('#umb-username', username);
await page.fill('#umb-passwordTwo', password);
await page.locator('[label-key="general_login"]').click();

// Assert
let usernameField = await page.locator('#umb-username');
let passwordField = await page.locator('#umb-passwordTwo');
await expect(error).toBeVisible();
await expect(usernameField).toBeVisible();
await expect(passwordField).toBeVisible();
});
// Assert
let usernameField = await page.locator('#umb-username');
let passwordField = await page.locator('#umb-passwordTwo');
await expect(error).toBeVisible();
await expect(usernameField).toBeVisible();
await expect(passwordField).toBeVisible();
});
});
2 changes: 1 addition & 1 deletion tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/mediaSection.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ test.describe('Media', () => {

// Assert
// Needs to wait before refreshing the media tree, otherwise the media files wont be moved to the folder yet
await page.waitForTimeout(1000);
await page.waitForTimeout(2500);
await umbracoUi.refreshMediaTree();
await page.locator('[data-element="tree-item-' + folderToMoveTooName + '"]').click();
for (const names of mediaFileTypes) {
Expand Down
Loading