Skip to content

Use GetRandomFileName for SQLite temp file #13439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bergmania merged 1 commit into from
Nov 30, 2022
Merged

Use GetRandomFileName for SQLite temp file #13439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteDatabaseCreator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ public void Create(string connectionString)
* always initializing in this way and it probably helps for non azure scenarios also (anytime persisting on a cifs mount for example).
*/

var tempFile = Path.GetTempFileName();
// Create a random file name using cryptographically strong random number generator (RNGCryptoServiceProvider)
var tempFile = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());

var tempConnectionString = new SqliteConnectionStringBuilder { DataSource = tempFile, Pooling = false };

using (var connection = new SqliteConnection(tempConnectionString.ConnectionString))
Expand Down