Only add global usings when ImplicitUsings is enabled#13322
Closed
ronaldbarendse wants to merge 9 commits intov11/devfrom
Closed
Only add global usings when ImplicitUsings is enabled#13322ronaldbarendse wants to merge 9 commits intov11/devfrom
ronaldbarendse wants to merge 9 commits intov11/devfrom
Conversation
4 tasks
1 task
Contributor
Author
|
Since this change potentially results in a code breaking change, I've targeted v11 and created a new PR: #13491. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As suggested by @JimBobSquarePants, the global usings in the
Umbraco.Cmspackage should only be added whenImplicitUsingsare enabled in the consuming project.Because users could have disabled
ImplicitUsingson their v10 project, but still depend on the global usings Umbraco adds (and therefore not have added explicit usings), this might be a source code breaking change. I've still targeted this PR to v10, so we can include it in the next minor version or otherwise easily cherry-pick into v11.Testing can be done by first disabling implicit usings in the
Umbraco.Web.UI(before applying this PR) by adding<ImplicitUsings>false</ImplicitUsings>to the project file and adding explicit usings for theSystem.*andMicrosoft.*namespaces (see docs).Next apply this PR and notice you now also have to add explicit usings for
Umbraco.Cms.Core.DependencyInjectionandUmbraco.Extensions👍🏻