New Backoffice: Return AnalyticsLevelViewModel instead of TelemetryLevel#13291
Closed
nikolajlauridsen wants to merge 18 commits intov11/devfrom
Closed
New Backoffice: Return AnalyticsLevelViewModel instead of TelemetryLevel#13291nikolajlauridsen wants to merge 18 commits intov11/devfrom
nikolajlauridsen wants to merge 18 commits intov11/devfrom
Conversation
…anup-management-api
…t-api' into v11/fix/openApi_duplicate_telemetry_level # Conflicts: # src/Umbraco.Cms.ManagementApi/OpenApi.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the duplicate TelemetryLevel property in the OpenApi schema.
This was caused by the
PagedViewModel<Telemetry>, basically it stems from the same issue we've had before with the serialization settings used by NSwag, and being unable to really change them globally, with the main issue here being that enums are serialized to integers by default.Specifically this comes from
PagedViewModel<T>.Itemsnot having the[JsonConverter(typeof(JsonStringEnumConverter))](and neither should it).I fixed this by instead returning the
PagedViewModel<AnalyticsLevelViewModel>.While it might be a bit overkill to create a ViewModel for only one property, I think it's pretty sensible since
TelemetryLevelis a domain model, "it" should really not be concerned about presentation at all.Created a new branch for this: #13298