Collect new .xml language files from different sources

[elit0451]

Details

• Gets .xml files for new languages (languages that Umbraco doesn't support) from other sources than umbraco/config/lang/, like:
  • /App_Plugins/mypackage/Lang/ - physical files or from RCLs
  • config/lang/ - physical files

Test

• Pick a language from the list;
  • For the example, I chose Bulgarian (bg);
• Create the following bg.xml file:

<?xml version="1.0" encoding="utf-8"?>
<language alias="bg" intName="Bulgarian" localName="български" lcid="" culture="bg-BG">
  <area alias="login">
    <key alias="greeting0">(BG) Happy super Sunday</key>
    <key alias="greeting1">(BG) Happy marvelous Monday</key>
    <key alias="greeting2">(BG) Happy tubular Tuesday</key>
    <key alias="greeting3">(BG) Happy wonderful Wednesday</key>
    <key alias="greeting4">(BG) Happy thunderous Thursday</key>
    <key alias="greeting5">(BG) Happy funky Friday</key>
    <key alias="greeting6">(BG) Happy Caturday</key>
	</area>
  <area alias="sections">
    <key alias="translation">(BG) Translation</key>
  </area>
</language>

• Place it in different places** and verify that Bulgarian comes as an option in the list of Languages that you can select the menus and dialogues to be translated to, like here:
  

---

** Different places like:

• Umbraco.Cms.StaticAssets\wwwroot\App_Plugins\MyPackage\Lang;
• Umbraco.Web.UI\App_Plugins\UIPackage\Lang;
• Umbraco.Web.UI\config\lang;
• Umbraco.Web.UI\umbraco\config\lang;

---

• Switch the language to Bulgarian and verify that the name of the Translation section changes to "(BG) Translation";
• Try setting the default backoffice language in appsettings by setting the Umbraco.CMS.Global.DefaultUILanguage key and verify that the login screen greetings changed to the ones we specified in the bg.xml file;

  "Umbraco": {
    "CMS": {
      "Global": {
        "DefaultUILanguage": "bg-BG", // or just "bg"
      }
   }
}

• Delete the "packages" key from the "sections" area in en_us.xml file located in Umbraco.Core/EmbeddedResources/Lang/;

  <area alias="sections">
    <key alias="packages">Packages</key>
  </area>

and add the following new en_us.xml to either Umbraco.Cms.StaticAssets\wwwroot\App_Plugins\MyPackage\Lang or Umbraco.Web.UI\App_Plugins\UIPackage\Lang:

<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<language alias="en_us" intName="English (US)" localName="English (US)" lcid="" culture="en-US">
    <area alias="sections">
        <key alias="packages">Packages</key>
    </area>
</language>

• Verify that we can add new language keys for packages - basically check that we get a name for the packages section, instead of the [packages] key ;

• Verify that you can still override existing language translation keys - follow the Greeting section:
  • NB ❗ : Remember to change back the "DefaultUILanguage": "en-us".

[nikolajlauridsen]

Tests out good, and overall looks good to me, only found a couple of minor details 😄

[elit0451]

Thanks for the review @nikolajlauridsen, I will fix up the things you pointed out! 💪

[FrancisGroleau]

why filter out the user.xml files ? now if I add an en-CA.user.xml file it won't be taken as a Language file and so when the UmbracoErrorDescriberBase that uses the ILocalizedTextService can't retrieve the localized message for Identity Framework Errors ?

[elit0451]

Hi @FrancisGroleau 👋

Apologies for getting back to you just now. As I mentioned in a comment in the linked issue, user.xml files are for overriding existing translations:

If you want to create a 'user' translation file to override existing language translation keys, you need to have an .xml language file for the same language first, to be able to override anything.

So, once you have en-CA.xml file, it will be picked up as a language file 😌