Don't use legacy icon for action delete

[bjarnef]

Prerequisites

• I have added steps to test this contribution in the description below

Description

I noticed from time to time when opening the action delete, the icon was sometimes missing. It seems it required icon-icon-delete because useLegacyIcon wasn't set.

In #12403 this was changes so full icon name should be specified and core icons updated to use full icon name, but to be backward compatible it added the useLecacyIcon which is true by default, which mean it always requested an icon with icon- prefix + specified icon name.

However this was fixed here https://github.com/umbraco/Umbraco-CMS/pull/12403/files#diff-5233dfc5cb8dcc04b74ba67fc13b7c8833c80b63a76ed965e4d0d89cc7f04dcaR134 but somehow is reverted in core. I guess it has been a merge conflict somewhere, which discarded this change.

Before

chrome_Gub9MkBAyj.mp4

After

chrome_vbEGcWZv63.mp4

[github-actions]

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[bjarnef]

@AndyButland I have noticed this as well on a project on Umbraco 10.2.0 and Forms v10.1.2
I forms used constants from core, but it's own tree controllers, it may need to add the useLegacyIcon: true parameter to use the full icon name (which unfortunately wasn't the case in two parts of the backoffice UI previosly):
#12403
#12062

[AndyButland]

@bjarnef - yes, I noticed this the other day too. The "Create" icon was missing in Forms. Unfortunately useLegacyIcon looks like it wasn't introduced in CMS 10.0, which Forms depends on, and so we can't use it (at least without some reflection hacks). So instead I had to change the code to use this approach for creating the menu item instead.

Replaced:

menu.Items.Add<ActionNew>(LocalizedTextService, opensDialog: true);

With:

menu.Items.Add(new MenuItem("create", LocalizedTextService)
{
    Icon = "icon icon-add",
    OpensDialog = true,
});

[bjarnef]

@AndyButland yes, it seems the PR was first included in v10.1.0

Not just the create icon, also move, copy and delete.

I guess icon for Export menu action is handled a bit different. However on second right-click they show up.

[mikecp]

Thanks @bjarnef for spotting this regression and fixing it... again 😅👍

Cheers!

[AndyButland]

Not just the create icon, also move, copy and delete.

True, I hadn't noticed these... but I'll update them in the same way for V10, and then use the new syntax for V11.

[umbrabot]

Hi there @bjarnef!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 18th, 2022, 09:00 AM UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.