Hide colors from icon picker#13079
Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
@mikecp any chance you can review this one. It would be great to be able to hide colors ... and the icons are much better aligned in large overlay. |
|
Hi @bjarnef , |
|
Hi @bjarnef , Thanks for this PR, I checked and tested it and it works perfectly 👍 Cheers! |
* Ensure border is set so it doesn't jump on selection * Allow to hide color from icon picker * Use CSS grid instead to fill icons and with minimum width * Remove odd flex size * Set minimum to 60px instead






Prerequisites
Description
I noticed it wasn't possible to hide colors from icon picker infinite editor. Sometimes when using this in custom property editors etc. one may not need the colors, just a icon to select.
I also noticed it "jumped" a bit on icon selection, because it add a 1px border (so it need to 1px transparent border by default - or something else to compensate the 1px solid border on selection.
Furthermore it seems the icons didn't align well for different sizes of overlay. While it may work in small overlay, it would be difficult to adjust correct for medium and large overlays also.
I have replaced this with CSS grid instead with fill the icons to its container, a bit gap between and minimum
70px60px width for each icon.auto-fillfill the container, while I noticedauto-fitwould stretch the icon to full width when filtering for instance "umbraco".chrome_HGomCJuKDr.mp4
I have attached the dashboard from the video above: MyDashboard.zip