Skip to content

feat: adding item templates from old template package#12870

Closed
Mantus667 wants to merge 2 commits intoumbraco:contribfrom
Mantus667:feature/umbraco-item-templates
Closed

feat: adding item templates from old template package#12870
Mantus667 wants to merge 2 commits intoumbraco:contribfrom
Mantus667:feature/umbraco-item-templates

Conversation

@Mantus667
Copy link
Copy Markdown
Contributor

Integrating item templates from the v8 template package

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

For v8 we had item templates provided by the Packages.Templates templates pack.
These templates were provided by the Package Team. As with v9 Umbraco HQ provides general Dotnet templates for project/package, the team decided that we should move the item templates to the offical umbraco repo and be part of the official templates pack.

How to test:

  • Pack the templates locally
  • Install the templates from the local nuget package
  • Use the item templates to install them into an exisitng umbraco project

Integrating item templates from the v8 template package
@github-actions
Copy link
Copy Markdown

Hi there @Mantus667, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan nul800sebastiaan changed the base branch from v10/contrib to v11/contrib October 25, 2022 13:05
@nul800sebastiaan nul800sebastiaan changed the base branch from v11/contrib to contrib January 26, 2023 14:52
@nul800sebastiaan
Copy link
Copy Markdown
Member

@Mantus667 I think this relates to #12869 as well. Can you let us know if this is still relevant and correct? Or maybe there's new ideas at the moment?

@ronaldbarendse
Copy link
Copy Markdown
Contributor

@Mantus667 I think this relates to #12869 as well. Can you let us know if this is still relevant and correct? Or maybe there's new ideas at the moment?

Making it easier and faster to create packages/extensions will always be relevant, but we might want to verify whether the effort is indeed justified 😄

The first one to check will be how these item templates are exposed: can you only use the dotnet new CLI command (docs) or will these also be exposed in the IDE (e.g. similar to adding items to the Add New Item dialog in Visual Studio, as that can be done in another way)?

We should probably also use a similar structure as the UI Examples, where each created item has its own package.manifest file, as I don't think the item templates can update an existing package.manifest file, add translation keys to the XML files, etc.

And finally we should also look into how this will work in v13, as that will definitely change how things need to be done and potentially move this part to npm packages instead of using .NET 🤷🏻

@nul800sebastiaan
Copy link
Copy Markdown
Member

Hey there @Mantus667! It's been a while since we've heard from you. We'd love to keep going on this one but it seems like it doesn't fit in for you at the moment. In order to keep things tidy, we'll close this one for now. Please let us know when you can get back to it, we can either resurrect this PR or go for an attempt number 2! Thanks again for all your work on this and we hope to hear from you soon! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants