Skip to content

Trap lightbox, and fix and bug in umbfocuslock found under test #12787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rammi987 wants to merge 3 commits into from
Closed

Trap lightbox, and fix and bug in umbfocuslock found under test #12787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dab0d1
Trap lightbox, and fix and bug in umbfocuslock found under test
Aug 5, 2022
bf3f913
Remove unreadable line and clean it and top performed it
Aug 17, 2022
6809bf8
Remove uneccery ng-attr and change indexOf to includes
Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbfocuslock.directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@
// Whenever the DOM changes ensure the list of focused elements is updated
function domChange() {
getFocusableElements();

// When an element is remove or become not focusable, but focus is on it,
// we need to ensure a now focus inside the trap, else the focus can escape the trap.
if (focusableElements.includes(document.activeElement) === false) {
setElementFocus();
}
}

// Start observing the target node for configured mutations
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI.Client/src/views/packages/views/repo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ <h4><strong><localize key="general_searchNoResult">Sorry, we can not find what y
ng-if="vm.lightbox.show"
items="vm.lightbox.items"
active-item-index="vm.lightbox.activeIndex"
umb-focus-lock="true"
on-close="vm.closeLightbox">
</umb-lightbox>

Expand Down