Skip to content

Simplify code in UmbracoViewPage#12528

Merged
Zeegaan merged 1 commit intoumbraco:v10/contribfrom
bjarnef:v10/feature/umbraco-view-page-simplify
Jun 2, 2022
Merged

Simplify code in UmbracoViewPage#12528
Zeegaan merged 1 commit intoumbraco:v10/contribfrom
bjarnef:v10/feature/umbraco-view-page-simplify

Conversation

@bjarnef
Copy link
Copy Markdown
Contributor

@bjarnef bjarnef commented Jun 2, 2022

Prerequisites

  • I have added steps to test this contribution in the description below

Description

A few adjustments in UmbracoViewPage to simplify code.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 2, 2022

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Copy Markdown
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bjarnef!
Will merge once the tests are happy 🚀

@Zeegaan Zeegaan merged commit 4238e2a into umbraco:v10/contrib Jun 2, 2022
@bjarnef bjarnef deleted the v10/feature/umbraco-view-page-simplify branch June 2, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants