Merged
Conversation
added 6 commits
May 6, 2022 10:15
…ld-warnings-in-Core # Conflicts: # src/Umbraco.Core/Composing/ComponentComposer.cs # src/Umbraco.Core/Configuration/ConfigureConnectionStrings.cs # src/Umbraco.Core/Configuration/Models/ConnectionStrings.cs # src/Umbraco.Core/Constants-System.cs # src/Umbraco.Core/DependencyInjection/IUmbracoBuilder.cs # src/Umbraco.Core/DependencyInjection/UmbracoBuilder.CollectionBuilders.cs # src/Umbraco.Core/DependencyInjection/UmbracoBuilder.Collections.cs # src/Umbraco.Core/DependencyInjection/UmbracoBuilder.Configuration.cs # src/Umbraco.Core/DependencyInjection/UmbracoBuilder.cs # src/Umbraco.Core/Deploy/ArtifactBase.cs # src/Umbraco.Core/Deploy/ArtifactDeployState.cs # src/Umbraco.Core/Deploy/ArtifactDeployStateOfTArtifactTEntity.cs # src/Umbraco.Core/Deploy/IArtifactSignature.cs # src/Umbraco.Core/Deploy/IDataTypeConfigurationConnector.cs # src/Umbraco.Core/Deploy/IValueConnector.cs # src/Umbraco.Core/Extensions/ConnectionStringExtensions.cs # src/Umbraco.Core/Install/Models/UserModel.cs # src/Umbraco.Core/Models/ContentEditing/ContentItemDisplay.cs # src/Umbraco.Core/Models/Mapping/ContentVariantMapper.cs # src/Umbraco.Core/Models/Mapping/MemberTabsAndPropertiesMapper.cs # src/Umbraco.Core/Models/Membership/MemberExportModel.cs # src/Umbraco.Core/Persistence/Repositories/ITemplateRepository.cs # src/Umbraco.Core/Services/FileService.cs # src/Umbraco.Core/Services/IFileService.cs # src/Umbraco.Core/Services/ILocalizationService.cs # src/Umbraco.Core/Services/IMediaService.cs # src/Umbraco.Core/Services/IMemberService.cs # src/Umbraco.Core/Services/IMembershipRoleService.cs # src/Umbraco.Core/Services/LocalizationService.cs # src/Umbraco.Core/Services/MediaService.cs # src/Umbraco.Core/Services/MemberService.cs # src/Umbraco.Core/Services/MetricsConsentService.cs
Contributor
nikolajlauridsen
left a comment
nikolajlauridsen
left a comment
There was a problem hiding this comment.
First round of findings :D
src/Umbraco.Core/Configuration/Models/RequestHandlerSettings.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Core/ContentApps/ContentAppFactoryCollectionBuilder.cs
Outdated
Show resolved
Hide resolved
Contributor
nikolajlauridsen
left a comment
nikolajlauridsen
left a comment
There was a problem hiding this comment.
Another batch of files reviewed, only 800 to go 🎉
src/Umbraco.Core/Models/PublishedContent/PublishedContentBase.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Core/Models/PublishedContent/PublishedContentType.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Core/Models/PublishedContent/PublishedPropertyType.cs
Outdated
Show resolved
Hide resolved
Contributor
nikolajlauridsen
left a comment
nikolajlauridsen
left a comment
There was a problem hiding this comment.
Another batch :D
src/Umbraco.Core/Notifications/ContentTypeRefreshedNotification.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Core/Notifications/ContentTypeSavingNotification.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Core/Notifications/ContentUnpublishingNotification.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Core/Notifications/DataTypeCacheRefresherNotification.cs
Outdated
Show resolved
Hide resolved
Contributor
nikolajlauridsen
left a comment
nikolajlauridsen
left a comment
There was a problem hiding this comment.
This should be the last ones :)
src/Umbraco.Core/Strings/UrlSegmentProviderCollectionBuilder.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Core/WebAssets/CustomBackOfficeAssetsCollectionBuilder.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…r.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…Builder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…ication.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…ation.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…cation.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…cation.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…ion.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…tion.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…tion.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…ication.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…n.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
…ld-warnings-in-Core # Conflicts: # src/Umbraco.Core/Actions/ActionAssignDomain.cs # src/Umbraco.Core/Actions/ActionDelete.cs # src/Umbraco.Core/Configuration/ITypeFinderSettings.cs # src/Umbraco.Core/Configuration/Models/ActiveDirectorySettings.cs # src/Umbraco.Core/Configuration/Models/BasicAuthSettings.cs # src/Umbraco.Core/Constants-Configuration.cs # src/Umbraco.Core/DependencyInjection/ServiceCollectionExtensions.cs # src/Umbraco.Core/Routing/UrlProvider.cs # src/Umbraco.Core/Security/IBackofficeSecurity.cs # src/Umbraco.Core/Services/BasicAuthService.cs # src/Umbraco.Core/Services/ContentTypeServiceBaseOfTRepositoryTItemTService.cs # src/Umbraco.Core/Services/IBasicAuthService.cs
Signed-off-by: Zeegaan <nge@umbraco.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
string.Substring(1)intostring[1..]instead