V10: fix build warnings infrastructure by Zeegaan · Pull Request #12369 · umbraco/Umbraco-CMS

Zeegaan · 2022-05-06T06:24:57Z

Notes

Removed lots of build warnings in the infrastructure project, but not without more wierdness!
dotnet format will turn string.Substring(1) into string[1..] instead
Please view v10: Fix build warnings in Web.Common #12349 & V10: Build warnings in Web.Website #12332 for more common problems!
Fixed dotnet format putting obsoletes

How to review

A great tip from @nikolajlauridsen is to remove whitespace changes when reviewing the files changed!
Click the cogwheel to open the settings menu, enable "Hide whitespace" and click "Apply and reload"

…ld-warnings-Infrastructure # Conflicts: # src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Repositories.cs # src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs # src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs # src/Umbraco.Infrastructure/Scoping/Scope.cs # src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs # src/Umbraco.Infrastructure/Security/MemberUserStore.cs

# Conflicts: # src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TemplateRepository.cs

# Conflicts: # src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs # src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.MappingProfiles.cs # src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Repositories.cs # src/Umbraco.Infrastructure/Deploy/IGridCellValueConnector.cs # src/Umbraco.Infrastructure/Install/InstallSteps/DatabaseConfigureStep.cs # src/Umbraco.Infrastructure/Install/InstallSteps/NewInstallStep.cs # src/Umbraco.Infrastructure/Install/UnattendedUpgrader.cs # src/Umbraco.Infrastructure/Migrations/Install/DatabaseBuilder.cs # src/Umbraco.Infrastructure/Models/GridValue.cs # src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs # src/Umbraco.Infrastructure/PropertyEditors/GridPropertyEditor.cs # src/Umbraco.Infrastructure/Runtime/RuntimeState.cs # src/Umbraco.Infrastructure/Scoping/Scope.cs # src/Umbraco.Infrastructure/Templates/HtmlMacroParameterParser.cs

nikolajlauridsen

Not quite done reviewing 730/835, but don't want to lose my review progress, so I'll submit it in two parts

src/Umbraco.Infrastructure/Cache/DistributedCacheBinder_Handlers.cs

src/Umbraco.Infrastructure/Cache/DistributedCacheExtensions.cs

src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.DistributedCache.cs

src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Repositories.cs

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TagRepository.cs

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserGroupRepository.cs

src/Umbraco.Infrastructure/Persistence/SqlContextExtensions.cs

src/Umbraco.Infrastructure/Persistence/UmbracoDatabaseFactory.cs

src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/ImageCropperValue.cs

nikolajlauridsen

Found a few more things, other than that LGTM 💪

src/Umbraco.Infrastructure/Routing/ContentFinderByConfigured404.cs

src/Umbraco.Infrastructure/Security/ClaimsIdentityExtensions.cs

...aco.Infrastructure/Serialization/AutoInterningStringKeyCaseInsensitiveDictionaryConverter.cs

src/Umbraco.Infrastructure/Suspendable.cs

…DistributedCache.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…Repositories.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…er.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…tor.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…nsions.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…erPropertiesAsColumns.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…r.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…pper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…per.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…ilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…torBase.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

…ExternalLoginRepository.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

# Conflicts: # src/Umbraco.Infrastructure/Configuration/JsonConfigManipulator.cs # src/Umbraco.Infrastructure/Install/InstallHelper.cs # src/Umbraco.Infrastructure/Install/InstallSteps/DatabaseConfigureStep.cs # src/Umbraco.Infrastructure/Install/InstallSteps/DatabaseUpgradeStep.cs # src/Umbraco.Infrastructure/Install/InstallSteps/NewInstallStep.cs # src/Umbraco.Infrastructure/Migrations/Install/DatabaseBuilder.cs # src/Umbraco.Infrastructure/Persistence/UmbracoDatabaseFactory.cs # src/Umbraco.Infrastructure/Scoping/LegacyIScopeProvider.cs # src/Umbraco.Infrastructure/Services/CacheInstructionService.cs

Nikolaj Geisle added 10 commits May 4, 2022 10:49

Run code cleanup

285781b

Run dotnet format

1979e6d

Start manual fixes

1a7acba

Manual fixing of warnings

2bdad52

Fix nullability in columnalias

7bd1871

Fix tests

59488f6

Merge branch 'v10/dev' into v10/bugfix/fix-build-warnings-Infrastructure

8d7d9e4

# Conflicts: # src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TemplateRepository.cs

Fix up after merge

66a49b7

nikolajlauridsen reviewed May 25, 2022

View reviewed changes

Zeegaan mentioned this pull request May 30, 2022

V10: Fix build warnings umbraco.persistence #12502

Merged

nikolajlauridsen reviewed May 30, 2022

View reviewed changes

Zeegaan mentioned this pull request May 31, 2022

V10: fix build warnings in test projects #12509

Merged

Zeegaan and others added 16 commits May 31, 2022 15:30

Start updating after review

9e7c4ab

Update editorconfig to contain new static & const rules

14b2cca

Fix up editorconfig to not contain duplicate rules

508327e

Fix up static member names

fce3756

Fix up according to review

a817df3

Update src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.…

1026659

…DistributedCache.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.…

dbf60f9

…Repositories.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.…

da50863

…Repositories.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs

30237ba

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs

7867ccd

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs

1a3ce86

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs

5d74430

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs

831d104

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Examine/ExamineUmbracoIndexingHandl…

727bbf1

…er.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Examine/PublishedContentIndexPopula…

b54cffb

…tor.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Extensions/InstanceIdentifiableExte…

4af20fd

…nsions.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Zeegaan and others added 27 commits June 1, 2022 13:43

Update src/Umbraco.Infrastructure/Migrations/Upgrade/V_10_0_0/AddMemb…

7ab14e2

…erPropertiesAsColumns.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs

122b2f9

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs

6ad4c4e

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs

44d563c

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs

f8501c3

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs

c0cc6fd

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs

2e2293c

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs

96e1f9d

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Dtos/ExternalLoginDto.cs

25baebc

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/AccessMapper.cs

db789ec

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/AuditEntryMappe…

27d20f7

…r.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/MediaMapper.cs

ad41121

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/MemberMapper.cs

e4ec837

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/PropertyGroupMa…

a606436

…pper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/PropertyGroupMa…

98e1e5c

…pper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/PropertyTypeMap…

489e9b4

…per.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/PropertyTypeMap…

d10fc51

…per.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/RelationTypeMap…

0e6aaf9

…per.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Mappers/RelationTypeMap…

572557b

…per.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/NPocoMapperCollectionBu…

3f2ee39

…ilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisi…

bd22002

…torBase.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Update src/Umbraco.Infrastructure/Persistence/Repositories/Implement/…

c2cb96c

…ExternalLoginRepository.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

Fix [..] to substring

2de0f07

Fix after merge with 10/dev

e6fd0b7

Fox ContentValueSetValidator.cs

2f44d5d

Update LoggerConfigExtensions

bbd53b0

Zeegaan merged commit f4e333c into v10/dev Jun 2, 2022

Zeegaan deleted the v10/bugfix/fix-build-warnings-Infrastructure branch June 2, 2022 06:18

jonnymuir mentioned this pull request Jul 14, 2022

Allow indexing variant nodes when not all variants are published - fixes issues 11383. #12669

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V10: fix build warnings infrastructure#12369

V10: fix build warnings infrastructure#12369
Zeegaan merged 61 commits intov10/devfrom
v10/bugfix/fix-build-warnings-Infrastructure

Zeegaan commented May 6, 2022 •

edited

Loading

Uh oh!

nikolajlauridsen left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikolajlauridsen left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Zeegaan commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

How to review

Uh oh!

nikolajlauridsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikolajlauridsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Zeegaan commented May 6, 2022 •

edited

Loading