Fix GetCropUrl() extension methods on UrlHelper#10527
Closed
ronaldbarendse wants to merge 3 commits intov8/contribfrom
Closed
Fix GetCropUrl() extension methods on UrlHelper#10527ronaldbarendse wants to merge 3 commits intov8/contribfrom
ronaldbarendse wants to merge 3 commits intov8/contribfrom
Conversation
Contributor
Author
|
The changes in this PR show up a bit weird, but if you look at the separate commits, you'll clearly see I've removed the offending These commits are also part of PR #10529, but that also contains new features. |
1 task
Contributor
Author
|
I'll close this PR as #10529 that includes these changes is now merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #10402.
Description
With the introduction of the new Media picker (v3 - with local crops), a new
GetCropUrl()extension method onUrlHelperwas added that causes aThe call is ambiguous between the following methods or propertiescompiler error when used with named parameters.This PR aligns the extension methods/parameters on
UrlHelperwith those onIPublishedContent. Some code might still need updating, but the impact would be a lot lower (as the new extension method has less parameters that can cause ambiguity) and the change will be a lot easier: