Support To Change Anchor Point #548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by dragging the list down, then re-dock the panel by dragging the list up, release, then drag down on the list, it would cause the panel to intercept when it shouldn't. 2) If you were rapidly scrolling in the list by repeating the dragging motion, the list would stop every second drag because the event was being changed from a move to a down.
…panel will stop at the anchor point first before going to the expanded or collapsed state. This is unless the user has scrolled past the anchor point.
Fixed two nested scroll issues
Fixed anchor point scrolling issue. If anchor point is set, then the …
Add support for RecyclerView
This allows custom behavior for nested scrolling, or extending the scroll panel to support different scrollable types.
…ion of the cursor, not the moved position to get the view. This was causing dragging from close to the panel edge to not work correctly.
In very rare cases a multi finger touch in the main section can cause an exception.
|
Looks like a lot of lines have the whitespace changed, can you revert that? I can't properly review change without that. |
fix typos
Set getScrollableViewScrollPosition to protected
Use decorated RecyclerView child sizes
Fixed drag state idle check
Dragging from close to the edge of the panel doesn't work as expected.
…nimated settling is in progress.
Changed mPanelSlideListeners to a CopyOnWriteArrayList. Addresses #695.
Fix potential NPEs and synchronization errors.
I have updated the 26.+ to the correct version. And yes the Gradle version also has to be upgraded in the file AndroidSlidingUpPanel/build.gradle Line no 8 to -> classpath 'com.android.tools.build:gradle:2.3.2' and Line no 26 to -> gradleVersion = '3.3'
This will allow child views with horizontally scrollable content to behave as expected, regardless of the state of the panel.
In SlidingUpPanelLayout.dispatchTouchEvent(), ignore horizontal scrolls
Fixed Bug: SlidingUpPanelLayout ignores setPanelState()
Update build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to change the anchor point and make the panel smooth slide to new position.
original issue: Multiple Anchor Point #542