-
Notifications
You must be signed in to change notification settings - Fork 34
Enable Storage of Histogram/ROC Objects #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 98.14% 98.34% +0.20%
==========================================
Files 53 53
Lines 5711 5922 +211
==========================================
+ Hits 5605 5824 +219
+ Misses 106 98 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Maybe adding noise, but at some point we might want to look at this other effort toward a histogram storage format: scikit-hep/uhi#105. Seems a lot more specific about just storing the data, without the plotting code, but that would be enough to speed our plotting up a lot. |
We need to support other kinds of plots too though :( Not sure if we want to combine a third party solution with an in-house one? |
|
I think we can discuss other formats but the issue I fixed in this PR is a general issue. So therefore I would delay adding new third-party solutions to later |
|
yeah I'm not saying we should delay this. I guess better to make this into an issue right? See #322. |
Summary
This pull request introduces the following changes
Histogramobjects.Histogram/ROCobjects. Only forResultsfor now.AuxResultswill need bigger changes.Migration notes
Overall, this PR modernises histogram handling by treating them as first-class, serialisable data objects while trimming redundant per-plot computation.
Conformity