Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved control in high-level interface for auxiliary plots #277

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

nikitapond
Copy link
Contributor

Summary

This pull request introduces the following changes

  • Allows passing purity and recall requirements from the plot_var_vtx_perf to make it easier to make plots given different requirements
  • Changes a requirement definition of recall/purtiy to now be >= instead of just >

Conformity

@nikitapond
Copy link
Contributor Author

cc @samvanstroud @jmw464 - the changes to make purity/recall requirements inclusive are something me and Sam discussed a while ago.

@samvanstroud
Copy link
Contributor

Looks good to me thanks @nikitapond

@samvanstroud samvanstroud merged commit aed0be5 into umami-hep:main Aug 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants