Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track origin confusion matrix padding fix #267

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

jmw464
Copy link
Contributor

@jmw464 jmw464 commented Jun 25, 2024

Summary

This pull request introduces the following changes

  • Fixes treatment of padded tracks when calculating CM

Conformity

@jmw464 jmw464 marked this pull request as ready for review June 26, 2024 00:02
@jmw464
Copy link
Contributor Author

jmw464 commented Jun 26, 2024

I think this could also be fixed further upstream but I don't want to introduce any additional assumptions into the confusion matrix code. Also tagging @LucioDerin

@samvanstroud
Copy link
Contributor

Thanks for this @jmw464, looks good

@samvanstroud samvanstroud merged commit fd220e1 into umami-hep:main Jun 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants