Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve yuma config #237

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Improve yuma config #237

merged 7 commits into from
Feb 19, 2024

Conversation

samvanstroud
Copy link
Contributor

@samvanstroud samvanstroud commented Feb 19, 2024

Summary

This pull request introduces the following changes

  • Improvements to yuma config - using wherever possible class init args to directly configure things

Relates to the following issues

Conformity

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9fafd9e) 97.18% compared to head (61596de) 97.15%.

Files Patch % Lines
puma/hlplots/configs.py 88.23% 2 Missing ⚠️
puma/hlplots/yuma.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   97.18%   97.15%   -0.03%     
==========================================
  Files          45       45              
  Lines        4472     4466       -6     
==========================================
- Hits         4346     4339       -7     
- Misses        126      127       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samvanstroud samvanstroud merged commit de99e3f into main Feb 19, 2024
7 of 9 checks passed
@samvanstroud samvanstroud deleted the yuma-again branch February 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant