Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: modify top label in Xbb and add catch for legacy tagger plotting #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philippgadow
Copy link
Contributor

Summary

This pull request introduces the following changes

  • modify the Xbb label in the high level plotting interface from top to tqqb.
  • add try / except block to catch cases where legacy configurations are plotted

Conformity

@samvanstroud
Copy link
Contributor

Looks good thanks @philippgadow! Would be great if @zcapjdb can take a quick look too :)

@zcapjdb
Copy link

zcapjdb commented Nov 8, 2023

This looks good to me. Although I'm not sure if we should only look at the fully contained tops by default for the plotting

@dkobylianskii
Copy link
Contributor

Hi @philippgadow ,

Thanks for the MR!
Could you please fix formatting and tests?

@samvanstroud
Copy link
Contributor

umami-hep/atlas-ftag-tools#55 should help here :)

@samvanstroud
Copy link
Contributor

Hi @philippgadow, just a gentle nudge on this, it would be good to have this merged since we actually updated the tools package version recently https://github.com/umami-hep/puma/blob/main/requirements.txt#L16. I can't remember if this would cause confusion but pinging @zcapjdb to let him know in any case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants