Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prob plots to HLAPI #183

Merged
merged 7 commits into from
May 31, 2023
Merged

Add prob plots to HLAPI #183

merged 7 commits into from
May 31, 2023

Conversation

samvanstroud
Copy link
Contributor

@samvanstroud samvanstroud commented May 30, 2023

Summary

This pull request introduces the following changes

  • Add function to plot tagger probabiltity histograms in the high level api
  • Add support for WP vlines in the tagger discriminant plots

Relates to the following issues

Conformity

Copy link
Contributor

@dkobylianskii dkobylianskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice, thanks!
I added some comments

puma/tests/test_histogram.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #183 (da3f55e) into main (3941474) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   97.25%   97.28%   +0.03%     
==========================================
  Files          33       33              
  Lines        2875     2914      +39     
==========================================
+ Hits         2796     2835      +39     
  Misses         79       79              
Impacted Files Coverage Δ
puma/tests/test_histogram.py 100.00% <ø> (ø)
puma/hlplots/results.py 94.79% <100.00%> (+0.85%) ⬆️
puma/hlplots/tagger.py 97.22% <100.00%> (+0.07%) ⬆️
puma/plot_base.py 90.30% <100.00%> (-0.09%) ⬇️
puma/tests/hlplots/test_results.py 99.32% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dkobylianskii
Copy link
Contributor

If you have time, you can fix tests for hlplots. Otherwise, we can merge now, and I will fix the tests in the next MR.

@samvanstroud
Copy link
Contributor Author

Thanks for the look @dkobylianskii, coverage should be fixed with the last two commits.

@samvanstroud samvanstroud merged commit 36fb586 into main May 31, 2023
@samvanstroud samvanstroud deleted the svanstro/add-prob-hits branch May 31, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants