Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Fraction Scans to high level API #178

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Conversation

samvanstroud
Copy link
Contributor

@samvanstroud samvanstroud commented Apr 24, 2023

Summary

This pull request introduces the following changes

Relates to the following issues

Todo:

  • tests

Conformity

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #178 (808aee0) into main (c9549ad) will increase coverage by 0.23%.
The diff coverage is 98.07%.

❗ Current head 808aee0 differs from pull request most recent head 07124d8. Consider uploading reports for the commit 07124d8 to get more accurate results

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   96.73%   96.97%   +0.23%     
==========================================
  Files          32       33       +1     
  Lines        2881     2944      +63     
==========================================
+ Hits         2787     2855      +68     
+ Misses         94       89       -5     
Impacted Files Coverage Δ
puma/fraction_scan.py 80.00% <80.00%> (ø)
puma/hlplots/tagger.py 97.14% <92.85%> (+2.33%) ⬆️
puma/hlplots/results.py 93.93% <98.14%> (+3.93%) ⬆️
puma/tests/hlplots/test_results.py 99.26% <100.00%> (+0.09%) ⬆️
puma/tests/hlplots/test_tagger.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@samvanstroud
Copy link
Contributor Author

@dkobylianskii
Copy link
Contributor

Thanks!
For me looks fine.

@samvanstroud
Copy link
Contributor Author

Thanks! For me looks fine.

Many thanks @dkobylianskii ! if you can approve the changes then I can merge, cheers,

@samvanstroud samvanstroud merged commit c86b64b into main Apr 25, 2023
@samvanstroud samvanstroud deleted the svanstro/frac-scan branch April 25, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants