Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit, store tagger scores as structured array #177

Merged
merged 9 commits into from
Apr 24, 2023

Conversation

samvanstroud
Copy link
Contributor

@samvanstroud samvanstroud commented Apr 18, 2023

Summary

This pull request introduces the following changes

  • Update pre-commit consolidating to ruff
  • store tagger scores as structured array

Relates to the following issues

Conformity

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #177 (12483d8) into main (b233f47) will increase coverage by 0.07%.
The diff coverage is 97.97%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   96.66%   96.73%   +0.07%     
==========================================
  Files          32       32              
  Lines        2880     2881       +1     
==========================================
+ Hits         2784     2787       +3     
+ Misses         96       94       -2     
Impacted Files Coverage Δ
puma/__init__.py 100.00% <ø> (ø)
puma/metrics.py 96.49% <ø> (ø)
puma/tests/utils/test_logging.py 100.00% <ø> (ø)
puma/utils/logging.py 100.00% <ø> (ø)
puma/hlplots/tagger.py 94.80% <90.90%> (+0.97%) ⬆️
puma/hlplots/results.py 90.00% <94.44%> (ø)
puma/histogram.py 95.31% <100.00%> (-0.05%) ⬇️
puma/hlplots/__init__.py 100.00% <100.00%> (ø)
puma/line_plot_2d.py 100.00% <100.00%> (ø)
puma/pie.py 100.00% <100.00%> (ø)
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@samvanstroud samvanstroud changed the title Draft: Update pre-commit Update pre-commit Apr 19, 2023
@samvanstroud samvanstroud changed the title Update pre-commit Update pre-commit, store tagger scores as structured array Apr 21, 2023
@samvanstroud
Copy link
Contributor Author

samvanstroud commented Apr 21, 2023

Could I get a review from one of @afroch @dkobylianskii @philippgadow? there are a lot of changes but they are almost all automatic fixes from the updated linting, so I don't think this needs to be scrutinised too closely.

Copy link
Contributor

@afroch afroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it looks fine to me. Maybe we can set the max line length again to 88. But just a small thing that I wanted to bring up

docs/sphinx_build_multiversion.py Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
Copy link
Contributor

@dkobylianskii dkobylianskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it looks fine
Thanks, Sam

puma/histogram.py Outdated Show resolved Hide resolved
Co-authored-by: Dmitrii Kobylianskii <[email protected]>
@samvanstroud
Copy link
Contributor Author

@afroch @dkobylianskii thanks for taking a look. The suggestions have been implemented, if you are able to approve that would be great!

@samvanstroud samvanstroud merged commit c9549ad into main Apr 24, 2023
@samvanstroud samvanstroud deleted the svanstro/update-precommit branch April 24, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Ruff and pre-commit.ci
4 participants