Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yratio bug, add test cases #175

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Fix yratio bug, add test cases #175

merged 4 commits into from
Apr 17, 2023

Conversation

dkobylianskii
Copy link
Contributor

@dkobylianskii dkobylianskii commented Apr 17, 2023

Summary

This pull request introduces the following changes

  • Fix bug of not setting y_ratio plots limits

Relates to the following issues

Do we need to have a changelog entry in this case?

Conformity

@codecov-commenter
Copy link

Codecov Report

Merging #175 (6ae584f) into main (b764bbc) will increase coverage by 0.17%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   96.25%   96.43%   +0.17%     
==========================================
  Files          30       30              
  Lines        2646     2667      +21     
==========================================
+ Hits         2547     2572      +25     
+ Misses         99       95       -4     
Impacted Files Coverage Δ
puma/plot_base.py 90.39% <100.00%> (+2.10%) ⬆️
puma/tests/test_plot_base.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@samvanstroud samvanstroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very welcome, thanks @dkobylianskii, I tend to agree to keep the interface now that it is there.

@dkobylianskii
Copy link
Contributor Author

This is very welcome, thanks @dkobylianskii, I tend to agree to keep the interface now that it is there.

Should I add a changelog entry for bug fixes or not?

@samvanstroud
Copy link
Contributor

This is very welcome, thanks @dkobylianskii, I tend to agree to keep the interface now that it is there.

Should I add a changelog entry for bug fixes or not?

Yes definitely! Thanks

@dkobylianskii dkobylianskii merged commit 9090c99 into main Apr 17, 2023
@dkobylianskii dkobylianskii deleted the yratio-fix branch April 17, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants