Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Xbb in high level API #157

Merged
merged 9 commits into from
Feb 24, 2023
Merged

Support Xbb in high level API #157

merged 9 commits into from
Feb 24, 2023

Conversation

samvanstroud
Copy link
Contributor

@samvanstroud samvanstroud commented Feb 20, 2023

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #157 (991fb3e) into main (4cf40b3) will decrease coverage by 0.28%.
The diff coverage is 76.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   95.70%   95.43%   -0.28%     
==========================================
  Files          30       30              
  Lines        2632     2628       -4     
==========================================
- Hits         2519     2508      -11     
- Misses        113      120       +7     
Impacted Files Coverage Δ
puma/tests/utils/test_utils.py 100.00% <ø> (ø)
puma/utils/__init__.py 71.05% <ø> (ø)
puma/hlplots/results.py 74.60% <64.70%> (-7.81%) ⬇️
puma/hlplots/tagger.py 94.36% <76.92%> (-3.97%) ⬇️
puma/plot_base.py 88.28% <83.33%> (+2.34%) ⬆️
puma/roc.py 93.65% <85.71%> (-0.14%) ⬇️
puma/histogram.py 95.83% <100.00%> (-0.03%) ⬇️
puma/tests/hlplots/test_results.py 93.22% <100.00%> (ø)
puma/tests/test_histogram.py 100.00% <100.00%> (ø)
puma/var_vs_eff.py 92.79% <100.00%> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afroch
Copy link
Contributor

afroch commented Feb 20, 2023

Hi @samvanstroud. PR looks good to me. The only think that could be fixed is the code coverage. Otherwise it's good to go

@samvanstroud
Copy link
Contributor Author

Hi @samvanstroud. PR looks good to me. The only think that could be fixed is the code coverage. Otherwise it's good to go

Thanks for taking a look @afroch, this was due to a badly named test, should be fixed now

@afroch afroch merged commit 246c16b into main Feb 24, 2023
@afroch afroch deleted the svanstro/xbb-support branch February 24, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants