Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixate the python container version #153

Merged
merged 7 commits into from
Feb 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
linter:
runs-on: ubuntu-latest
container: python:3.8-slim
container: python:3.8.15-slim
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand All @@ -20,7 +20,7 @@ jobs:
- run: flake8 .
pylint:
runs-on: ubuntu-latest
container: python:3.8-slim
container: python:3.8.15-slim
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand All @@ -31,7 +31,7 @@ jobs:
- run: pylint -j2 ./examples/*.py
darglint:
runs-on: ubuntu-latest
container: python:3.8-slim
container: python:3.8.15-slim
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand All @@ -40,7 +40,7 @@ jobs:
- run: darglint .
black:
runs-on: ubuntu-latest
container: python:3.8-slim
container: python:3.8.15-slim
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,12 @@ on:
jobs:
build-sphinx-docs:
runs-on: ubuntu-latest
container: python:3.8
container: python:3.8.15
steps:
- name: Checkout
uses: actions/checkout@master
with:
fetch-depth: 0 # otherwise, you will failed to push refs to dest repo

- name: Change Owner of Container Working Directory
run: chown root:root .

- name: Build Sphinx documentation
run: bash docs/build_docs.sh
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
unit_tests:
name: Unit tests
runs-on: ubuntu-latest
container: python:3.8-slim
container: python:3.8.15-slim
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand All @@ -31,7 +31,7 @@ jobs:
example_tests:
name: Example tests
runs-on: ubuntu-latest
container: python:3.8
container: python:3.8.15
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_todo_issue.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
update_issue:
name: Update the TODO Issue
runs-on: ubuntu-latest
container: python:3.8-slim
container: python:3.8.15-slim
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ The Docker images are built on GitHub and contain the latest version from the `m
The container registry with all available tags can be found
[here](https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-images/puma-images/container_registry/13727).

The `puma:latest` image is based on `python:3.8-slim` and is meant for users who want to use the latest version of `puma`. For each release, there is a corresponding tagged image.
The `puma:latest` image is based on `python:3.8.15-slim` and is meant for users who want to use the latest version of `puma`. For each release, there is a corresponding tagged image.
You can start an interactive shell in a container with your current working directory
mounted into the container by using one of the commands provided below.

Expand Down
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

### [Latest]

- Fixate the python container version [!153](https://github.com/umami-hep/puma/pull/153)
- Improve ROC format [#146](https://github.com/umami-hep/puma/pull/149)
- Fix for CI [!152](https://github.com/umami-hep/puma/pull/152)

Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.8-slim
FROM python:3.8.15-slim

# Copy the current version of the repo in the image
COPY . /puma_repo
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile_dev
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.8
FROM python:3.8.15

RUN apt update && apt install -y \
vim
Expand Down