Add Cargo.lock to repository #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html says: > If you’re building a non-end product, such as a rust library that > other rust packages will depend on, put Cargo.lock in your .gitignore. > If you’re building an end product, which are executable like > command-line tool or an application, or a system library with crate-type > of staticlib or cdylib, check Cargo.lock into git. Technically `telamon` (the crate) is a library, but its only users are the `kernels` and `telamon-capi` crates, which are respectively used through command-line tools and a system .so cdylib. Hence there are no good reasons not to keep the `Cargo.lock` in the repository, at least until the day (if it comes) there are other Rust packages (outside of this repo) which use `telamon` (the crate). This allows to have shared, known-working dependency versions across developers and machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
says:
Technically
telamon(the crate) is a library, but its only users arethe
kernelsandtelamon-capicrates, which are respectively usedthrough command-line tools and a system .so cdylib. Hence there are no
good reasons not to keep the
Cargo.lockin the repository, at leastuntil the day (if it comes) there are other Rust packages (outside of
this repo) which use
telamon(the crate).This allows to have shared, known-working dependency versions across
developers and machines.