Skip to content

Support automatically toggling room focus #477

Support automatically toggling room focus

Support automatically toggling room focus #477

GitHub Actions / clippy failed Aug 23, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (2)

src/windows/room/chat.rs|656 col 9| warning: unused variable: store
--> src/windows/room/chat.rs:656:9
|
656 | store: &mut ProgramStore,
| ^^^^^ help: if this is intentional, prefix it with an underscore: _store
|
= note: #[warn(unused_variables)] on by default
src/windows/room/scrollback.rs|95 col 5| warning: this loop could be written as a for loop
--> src/windows/room/scrollback.rs:95:5
|
95 | while let Some((i, (key, _))) = iter.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: for (i, (key, _)) in iter.by_ref()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
= note: #[warn(clippy::while_let_on_iterator)] on by default

Filtered Findings (0)

Annotations

Check warning on line 656 in src/windows/room/chat.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/windows/room/chat.rs#L656

warning: unused variable: `store`
   --> src/windows/room/chat.rs:656:9
    |
656 |         store: &mut ProgramStore,
    |         ^^^^^ help: if this is intentional, prefix it with an underscore: `_store`
    |
    = note: `#[warn(unused_variables)]` on by default
Raw output
src/windows/room/chat.rs:656:9:w:warning: unused variable: `store`
   --> src/windows/room/chat.rs:656:9
    |
656 |         store: &mut ProgramStore,
    |         ^^^^^ help: if this is intentional, prefix it with an underscore: `_store`
    |
    = note: `#[warn(unused_variables)]` on by default


__END__

Check warning on line 95 in src/windows/room/scrollback.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/windows/room/scrollback.rs#L95

warning: this loop could be written as a `for` loop
  --> src/windows/room/scrollback.rs:95:5
   |
95 |     while let Some((i, (key, _))) = iter.next() {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (i, (key, _)) in iter.by_ref()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
   = note: `#[warn(clippy::while_let_on_iterator)]` on by default
Raw output
src/windows/room/scrollback.rs:95:5:w:warning: this loop could be written as a `for` loop
  --> src/windows/room/scrollback.rs:95:5
   |
95 |     while let Some((i, (key, _))) = iter.next() {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (i, (key, _)) in iter.by_ref()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
   = note: `#[warn(clippy::while_let_on_iterator)]` on by default


__END__