Implement set/unset/show for alternative and canonical aliases #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit solves ulyssa#50 by providing a way to: - Set the canonical alias of a room (destroying the previous one if any) - Unset the canonical alias of a room (destroying the previous one if any) - Add an alternative alias to a room - Delete an alternative alias to a room (destroying it afterwards) Signed-off-by: lymkwi <[email protected]>
Signed-off-by: lymkwi <[email protected]>
This command lets you access some information about a room, shown as message info. With it, for now, you can show alternative aliases and the canonical alisa of a room. Signed-off-by: lymkwi <[email protected]>
* Remove unreachable!() to future proof for custom commands support * Print message when doing no-ops * Demote old canonical alias instead of deleting it * Check canonical_alias when removing alias * Use HashSet to avoid duplicate aliases in state event * Use Pager for long alias lists * Use HTTP 409 Conflict to catch when alias already exists
|
This is a really great addition! Thank you so much for adding this, @Lymkwi ! 🥳 While playing around with this, I ended up changing the behaviour when setting a new canonical alias to put it into the alt aliases instead, so that people have a natural way to set new canonical aliases while keeping the old around for joining. If someone does want to get rid of it, then they can do |
ulyssa
changed the title
ulyssa
changed the title
This was referenced Aug 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit solves #50 by providing a way to: