Use PositionFor instead of Position
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a node has a `//line` comment the position reported from `Position` will be based on that comment. However, when we suggest fixes in `golanngci-lint` we need to do this in the current file, even if it's generated. This will ensure we get the actual position in the potentially generated file and ignoring the comment directive.
5 tasks
elwint
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a node has a
//linecomment the position reported fromPositionwill be based on that comment. However, when we suggest fixes ingolanngci-lintwe need to do this in the current file, even if it's generated.This will ensure we get the actual position in the potentially generated file and ignoring the comment directive.
PositionForgolangci-lint