Apple MPS -> CPU NMS fallback strategy#9600
Merged
glenn-jocher merged 1 commit intomasterfrom Sep 26, 2022
Merged
Conversation
Until more ops are fully supported this update will allow for seamless MPS inference (but slower MPS to CPU transfer before NMS, so slower NMS times). Partially resolves #9596 Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until more ops are fully supported this update will allow for seamless MPS inference (but slower MPS to CPU transfer before NMS, so slower NMS times).
Partially resolves #9596
Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhanced compatibility for Metal Performance Shaders (MPS) in non_max_suppression function.
📊 Key Changes
🎯 Purpose & Impact
non_max_suppressionfunction works even if the MPS backend is used, preventing any potential issues due to incomplete MPS support.