Skip to content

Python check warning emoji#9238

Merged
glenn-jocher merged 1 commit intomasterfrom
update/python_check
Aug 31, 2022
Merged

Python check warning emoji#9238
glenn-jocher merged 1 commit intomasterfrom
update/python_check

Conversation

@glenn-jocher
Copy link
Copy Markdown
Member

@glenn-jocher glenn-jocher commented Aug 31, 2022

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved version checking logic in YOLOv5's utilities.

📊 Key Changes

  • Simplified the version check by streamlining the comparison logic.
  • The informative string s for version mismatch has been removed from the check_version function.

🎯 Purpose & Impact

  • The changes aim to reduce complexity in the version checking functionality, ensuring that it's easy to maintain and understand.
  • Removing the unused string s could potentially avoid confusion during debugging or when reading code, as it's no longer declared but not used.
  • Users are unlikely to notice any direct impact, but developers will benefit from cleaner code and more straightforward troubleshooting.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit 55b0096 into master Aug 31, 2022
@glenn-jocher glenn-jocher deleted the update/python_check branch August 31, 2022 16:53
@anshul-aggarwal
Copy link
Copy Markdown

Hi, the added warning emoji appears to be causing an error in some configurations, when the model is loaded through torch hub:

UnicodeEncodeError: 'ascii' codec can't encode characters in position 31-32: ordinal not in range(128)
Using the previous commit for loading the model worked.

@glenn-jocher
Copy link
Copy Markdown
Member Author

@anshul-aggarwal resolved in #9252

ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants