assert torch!=1.12.0 for DDP training#8621
Merged
glenn-jocher merged 2 commits intomasterfrom Jul 18, 2022
Merged
Conversation
for more information, see https://pre-commit.ci
This was
linked to
issues
Jul 18, 2022
Closed
This was referenced Jul 18, 2022
Closed
ctjanuhowski
pushed a commit
to ctjanuhowski/yolov5
that referenced
this pull request
Sep 8, 2022
* assert torch!=1.12.0 for DDP training * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated dependencies and streamlined Distributed Data Parallel (DDP) model instantiation.
📊 Key Changes
torchandtorchvisioninrequirements.txt, previously excluding problematic versions.train.pywith a newsmart_DDPfunction.train.py, resulting in cleaner code.smart_DDPfunction inutils/torch_utils.pythat includes version checks and conditions for DDP instantiation, ensuring compatibility and preventing usage with unsupported versions.🎯 Purpose & Impact
torchandtorchvisiondependencies may allow for wider compatibility with different versions of these libraries, potentially easing installation and upgrade processes.smart_DDPfunction centralizes DDP logic, making it easier to manage compatibility issues with PyTorch versions and reducing potential errors during multi-GPU training setups.train.pyandutils/torch_utils.py, the codebase becomes more maintainable and understandable, which benefits contributors and users alike.