Merged
Conversation
Protected divides in IOU function to resolve #8539
2 tasks
Contributor
|
@glenn-jocher Looks good! What about lines 232/233 and 250? There, it is also possible to divide with 0. Isn't it?: Lines 232 to 233 in 7dafd1c Line 250 in 7dafd1c |
Member
Author
|
@UnglvKitDe 233 is not a divide, the \ symbol means line continuation. The c2 on L250 is already protected by the Line 244 in 7dafd1c |
Contributor
|
@glenn-jocher You are right, srry didn't read correctly. |
UnglvKitDe
approved these changes
Jul 11, 2022
Contributor
|
@glenn-jocher Thanks for the quick fix! |
Member
Author
|
@UnglvKitDe PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
Shivvrat
pushed a commit
to Shivvrat/epic-yolov5
that referenced
this pull request
Jul 12, 2022
Protected divides in IOU function to resolve ultralytics#8539
ctjanuhowski
pushed a commit
to ctjanuhowski/yolov5
that referenced
this pull request
Sep 8, 2022
Protected divides in IOU function to resolve ultralytics#8539
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protected divides in IOU function to resolve #8539
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Optimization of bounding box intersection-over-union calculations in YOLOv5.
📊 Key Changes
eps) addition in the width and height calculations of bounding boxes.vterm in the Complete Intersection over Union (CIoU) loss calculation to prevent division by zero during the aspect ratio term computation.🎯 Purpose & Impact