Exclude torch==1.12.0, torchvision==0.13.0 (Fix #8395)#8497
Merged
glenn-jocher merged 1 commit intoultralytics:masterfrom Jul 6, 2022
Merged
Exclude torch==1.12.0, torchvision==0.13.0 (Fix #8395)#8497glenn-jocher merged 1 commit intoultralytics:masterfrom
glenn-jocher merged 1 commit intoultralytics:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
👋 Hello @mjun0812, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
Member
|
@mjun0812 thanks for the investigation and the PR. PR is merged! |
2 tasks
Shivvrat
pushed a commit
to Shivvrat/epic-yolov5
that referenced
this pull request
Jul 12, 2022
…tralytics#8497) Exclude torch==1.12.0, torchvision==0.13.0
ctjanuhowski
pushed a commit
to ctjanuhowski/yolov5
that referenced
this pull request
Sep 8, 2022
…tralytics#8497) Exclude torch==1.12.0, torchvision==0.13.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8395
There is a bug in PyTorch 1.12.0 regarding CUDA initialization.
Therefore, the environment variable "CUDA_VISIBLE_DEVICES" set after
import torchwill not work.This is a fatal problem because YOLOv5 uses CUDA_VISIBLE_DEVICES to allocate GPUs.
yolov5/utils/torch_utils.py
Lines 52 to 85 in fdc9d91
As mentioned in this Issue, the next version of PyTorch 1.12.1 will resolve this issue, so it is better to remove the buggy version 1.12.0 and the associated torchvision version from the
requirements.txtfile.If you have any comments, please do not hesitate to let me know.
Thanks.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated PyTorch requirements to exclude buggy versions.
📊 Key Changes
🎯 Purpose & Impact