Closed
Conversation
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
👋 Hello @QuentinCouton, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
Member
|
@QuentinCouton PR CI is failing most checks. Please review and fix. |
Member
|
Maybe try using |
Member
|
@QuentinCouton I've created PR #8210 which should automatically prefer MPS over CPU if supported/available for all YOLOv5 ops: train/val/detect/hub etc. Can you try this PR and let me know if this works for you? i.e.: import torch
# Model
model = torch.hub.load('ultralytics/yolov5:mps/prefer', 'yolov5s') # <-- PR here
model.cpu()
# Images
dir = 'https://ultralytics.com/images/'
imgs = [dir + f for f in ('zidane.jpg', 'bus.jpg')] # batch of images
# Inference
results = model(imgs)
results.print() # or .show(), .save() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Support for Apple's Metal Performance Shaders (MPS) backend added to the YOLOv5 model selection logic.
📊 Key Changes
hubconf.py.🎯 Purpose & Impact