Skip to content

Add warning emoji ⚠️ on --conf > 0.001 #8005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glenn-jocher merged 3 commits into from
May 27, 2022
Merged

Add warning emoji ⚠️ on --conf > 0.001 #8005

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1d39ae
Add warning emoji on `--conf > 0.001`
glenn-jocher May 27, 2022
452735c
Update val.py
glenn-jocher May 27, 2022
1b7cd89
Merge branch 'master' into val/emoji
glenn-jocher May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions val.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
from utils.callbacks import Callbacks
from utils.dataloaders import create_dataloader
from utils.general import (LOGGER, check_dataset, check_img_size, check_requirements, check_yaml,
coco80_to_coco91_class, colorstr, increment_path, non_max_suppression, print_args,
coco80_to_coco91_class, colorstr, emojis, increment_path, non_max_suppression, print_args,
scale_coords, xywh2xyxy, xyxy2xywh)
from utils.metrics import ConfusionMatrix, ap_per_class, box_iou
from utils.plots import output_to_target, plot_images, plot_val_study
Expand Down Expand Up @@ -363,7 +363,7 @@ def main(opt):

if opt.task in ('train', 'val', 'test'): # run normally
if opt.conf_thres > 0.001: # https://github.com/ultralytics/yolov5/issues/1466
LOGGER.info(f'WARNING: confidence threshold {opt.conf_thres} >> 0.001 will produce invalid mAP values.')
LOGGER.info(emojis(f'WARNING: confidence threshold {opt.conf_thres} > 0.001 produces invalid results ⚠️'))
run(**vars(opt))

else:
Expand Down