Remove formats variable to avoid pd conflict#7993
Merged
glenn-jocher merged 2 commits intomasterfrom May 26, 2022
Merged
Conversation
Member
Author
|
@sazzadhrz this PR is unrelated to PyTorch HUB. If you have a reproducible bug please submit a full bug report with exact code to reproduce, thank you! |
tdhooghe
pushed a commit
to tdhooghe/yolov5
that referenced
this pull request
Jun 10, 2022
* Remove `formats` variable to avoid `pd` conflict * Update export.py
ctjanuhowski
pushed a commit
to ctjanuhowski/yolov5
that referenced
this pull request
Sep 8, 2022
* Remove `formats` variable to avoid `pd` conflict * Update export.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved clarity and fixed export conditions in
yolov5model exporting and benchmark utilities.📊 Key Changes
formatstofmtsfor better readability inexport.py.formatslogic in benchmarking by callingexport.export_formats()directly within loop iterations.🎯 Purpose & Impact
export.export_formats()calls simplifies the code and may slightly improve performance in benchmarks by reducing redundancy.Overall, these changes contribute to a cleaner and more user-friendly codebase with better guidance on model exporting procedures.