Closed
Conversation
Attempt to define environment variable before utils.general loads.
Member
Author
|
Test code: import torch
# Model
model = torch.hub.load('ultralytics/yolov5:update/verbose_hub', 'yolov5s', verbose=False)
# Images
dir = 'https://ultralytics.com/images/'
imgs = [dir + f for f in ('zidane.jpg', 'bus.jpg')] # batch of images
# Inference
results = model(imgs)
results.print() # or .show(), .save() |
for more information, see https://pre-commit.ci
Member
Author
|
Test fails, all output still seen in console. Seems that our custom verbose argument conflicts with the default torch hub verbose argument. https://pytorch.org/docs/stable/hub.html#torch.hub.load |
Contributor
|
@glenn-jocher how about we rename our argument to yolo_verbose? |
Member
Author
|
@Powercube7 I can try that! |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Member
Author
|
Closing PR as replaced by PR #7550 |
Member
Author
|
@Powercube7 I've implemented your idea now in PR #7550 with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to define environment variable before utils.general loads.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Refinement of logging and error messaging in YOLOv5's download and creation functions.
📊 Key Changes
YOLOv5_VERBOSEto control verbosity.printstatements toLOGGER.infofor better control over logging.LOGGERvariable within the download functions for consistent logging._verboseinstead ofverbosewhere appropriate.🎯 Purpose & Impact
YOLOv5_VERBOSEenvironment variable provides unified verbosity control across different parts of the code.printtoLOGGER.infooffers developers a more granular logging level, which can help with debugging.