Context manager open(file) as f fixes#7289
Merged
glenn-jocher merged 2 commits intomasterfrom Apr 5, 2022
Merged
Conversation
2 tasks
2 tasks
open() fixopen(file) as f fixes
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* Flask context manager `open()` fix * Additional read context manager fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #7288
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhanced file handling for better resource management in yolov5.
📊 Key Changes
VOC.yamlto use a context manager for reading image ids.export.pyto use a context manager when reading and rewriting JSON files.models/common.pyto parse GraphDef with a context manager.example_request.pyinflask_rest_apito read image data within a context manager.restapi.py, possibly for better documentation clarity.🎯 Purpose & Impact
withstatement) ensures files are properly closed after operations, reducing the likelihood of file handle leaks.