-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Landscape Mode feature to App #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @john-rocky I was testing the app and noticed that this bar takes up 1/5 of the available space! Is it possible to remove it or make it transparent?
In landscape mode, the background color of the bottom toolbar has been made transparent so that the preview can be seen more widely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@john-rocky Landscape mode does not work in iPad 9th generation with iPadOS 17.5.1
@ambitious-octopus etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@john-rocky The app simply doesn't rotate when you put the device in landscape mode! Let me test it again and I'll give you more precise information!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the first PR to be merged, but this PR also contains changes related to YOLO-human. @john-rocky Can you make this PR integrate only landscape mode by removing all changes related to YOLO-human?
@ambitious-octopus |
@ambitious-octopus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glenn-jocher This PR is the first step towards integrating into the main branch! While I haven't been able to test it on a Mac due to lack of access, I did test it on an iPhone 15 using TestFlight, and it worked correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @john-rocky , I added some comments! Have you tested this branch?
@ambitious-octopus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@john-rocky Please keep the latest versions of plugins. Can you test it please?
@ambitious-octopus |
@john-rocky @ambitious-octopus hi guys! I implemented the swift formatting in What a mess. I meant to simplify things but it looks like I've really created a problem now with the other PRs. @ambitious-octopus let's sync up on the YOLO meeting tomorrow to discuss next steps. This PR seems good to go now, so I'm going to merge, and then let's focus on the next PRs here. @john-rocky I think let's wait on the Human PRs for now, we want to focus first on the simplest improvements to the base app, and then begin to add Tasks like Segment and Pose, but we want to do this an minimally as possible, as users are expecting this PR to be a simple place to start, so we do not want to overdo it with code and features as much as possible. |
@john-rocky @ambitious-octopus PR merged!! Thanks for the amazing effort on this! |
Add landscape mode.
The UI will be laid out according to the device orientation and video orientation will be displayed correctly. The detection box will also be displayed correctly. If the app has a preferred landscape UI, please let me know.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
This PR improves the iOS YOLO app's adaptability to different device orientations and includes various code optimizations and enhancements.
📊 Key Changes
updateVideoOrientation
method to dynamically adjust video capture orientation.🎯 Purpose & Impact