Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define fallback model.names from Predictor #9439

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Mar 31, 2024

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced class name retrieval in Ultralytics models for more flexibility.

📊 Key Changes

  • Modified how class names are obtained from models: now supports an additional method via self.predictor.
  • Code structure around retrieving model names has been refined for better clarity and maintainability.

🎯 Purpose & Impact

  • Purpose: The change aims to provide a more robust and flexible way of accessing class names in models, particularly when the direct names attribute isn't available.
  • Impact: Users and developers can now expect more consistent behavior when working with different Ultralytics models, potentially improving user experience and compatibility with a broader range of models. 🚀

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.92%. Comparing base (7ea2007) to head (5e4b1fd).

Files Patch % Lines
ultralytics/engine/model.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9439      +/-   ##
==========================================
- Coverage   76.92%   76.92%   -0.01%     
==========================================
  Files         117      117              
  Lines       14854    14857       +3     
==========================================
+ Hits        11427    11429       +2     
- Misses       3427     3428       +1     
Flag Coverage Δ
Benchmarks 36.72% <0.00%> (-0.01%) ⬇️
GPU 38.85% <0.00%> (+<0.01%) ⬆️
Tests 72.05% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glenn-jocher glenn-jocher merged commit b530a30 into main Mar 31, 2024
14 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch March 31, 2024 04:33
hmurari pushed a commit to hmurari/ultralytics that referenced this pull request Apr 17, 2024
gkinman pushed a commit to Octasic/ultralytics that referenced this pull request May 30, 2024
puzhiyuan pushed a commit to puzhiyuan/ultralytics that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when try export yolov8 custom trained model to onnx format, new exported model names property is None.
1 participant