Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Google DNS for is_online() #10095

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Check Google DNS for is_online() #10095

merged 2 commits into from
Apr 17, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 17, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvements in code coverage reporting and online connectivity check for Ultralytics projects.

πŸ“Š Key Changes

  • Adjusted the verbosity level during the benchmarking of the Segmentation Model in CI workflows.
  • Enhanced the online status check logic to test connectivity against multiple DNS servers (Cloudflare and Google).

🎯 Purpose & Impact

  • Benchmarking tweak: Slight reduction in logging verbosity during testing aims to streamline the CI process and potentially reduce log clutter, making it easier to spot important details.
  • Connectivity check enhancement: The addition of an additional DNS server for online status checks improves reliability. This ensures that the software can reliably detect internet connectivity by checking against two major DNS services, reducing the chances of a false offline status due to a single DNS server being unreachable.
  • User impact: These updates are mostly under-the-hood, but they contribute to more robust and efficient development practices for Ultralytics projects. Users might not see immediate changes in usage, but these improvements support the goal of delivering stable and reliable software by enhancing the quality assurance processes. πŸš€

@glenn-jocher glenn-jocher merged commit c54b013 into main Apr 17, 2024
10 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch April 17, 2024 03:09
hmurari pushed a commit to hmurari/ultralytics that referenced this pull request Apr 17, 2024
dimidagd pushed a commit to dimidagd/ultralytics_dotav2 that referenced this pull request Apr 18, 2024
gkinman pushed a commit to Octasic/ultralytics that referenced this pull request May 30, 2024
iamdgarcia pushed a commit to iamdgarcia/ultralytics_16U that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant