fix(#25): Mark certain structs as !Sync #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some objects in dlib are not Thread Safe, thus they should be marked as !Sync to do this in stable Rust, you add a field with `UnsafeCell`. If you don't need `UnsafeCell`, then just put it inside a `PhantomData`, this tells the type system that your type should act as if it held an `UnsafeCell`, but it doesn't actually have it. When [`negative_impls`](rust-lang/rust#68318) is stabilized, we can use that instead. I would suggest applying this patch then bumping the crate version to 0.3.1 and yanking 0.3.0 to prevent people from downloading the previous version.
|
Confirmed as your issue #25 (comment)! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some objects in dlib are not Thread Safe, thus they should be marked as !Sync to do this in stable Rust, you add a field with
UnsafeCell.If you don't need
UnsafeCell, then just put it inside aPhantomData, this tells the type system that your type should act as if it held anUnsafeCell, but it doesn't actually have it.When
negative_implsis stabilized, we can use that instead.I would suggest applying this patch then bumping the crate version to 0.3.1 and yanking 0.3.0 to prevent people from downloading the previous version.
Closes #25