fix sass package consumption via @use
#1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 94f867b:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 82.08% 82.08%
=======================================
Files 212 212
Lines 11184 11184
Branches 1343 1343
=======================================
Hits 9180 9180
Misses 1378 1378
Partials 626 626 ☔ View full report in Codecov by Sentry. |
schiller-manuel
force-pushed
the
fix-sass-import
branch
from
6ba462f to
7ab88fd
Compare
since `@import` is deprecated (https://sass-lang.com/blog/import-is-deprecated/), `@use` should be used (https://sass-lang.com/documentation/at-rules/use/) in order to allow importing from a nodejs package via `@use` we must annotate the `exports` field appropriately, see https://sass-lang.com/documentation/at-rules/use/#node-js-package-importer
schiller-manuel
force-pushed
the
fix-sass-import
branch
from
7ab88fd to
94f867b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since
@importis deprecated (https://sass-lang.com/blog/import-is-deprecated/),@useshould be used (https://sass-lang.com/documentation/at-rules/use/)in order to allow importing from a nodejs package via
@usewe must annotate theexportsfield appropriately, see https://sass-lang.com/documentation/at-rules/use/#node-js-package-importer