Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add okType to ConfirmModalProps #1129

Merged

Conversation

schiller-manuel
Copy link
Contributor

should this be a string instead of "danger"?

Copy link

codesandbox bot commented Nov 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 8:54pm
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 8:54pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview Nov 4, 2024 8:54pm

Copy link

codesandbox-ci bot commented Nov 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 633e2e0:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (f555509) to head (633e2e0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files         212      212           
  Lines       11184    11184           
  Branches     1343     1343           
=======================================
  Hits         9180     9180           
  Misses       1378     1378           
  Partials      626      626           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ukrbublik
Copy link
Owner

I think okType is not used

@schiller-manuel
Copy link
Contributor Author

well it occurs in the documentation and examples and could potentially be used by a UI library.

@ukrbublik
Copy link
Owner

Ok, please use string instead of "danger"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants